New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tahoe-lafs: clean up inputs #59231
tahoe-lafs: clean up inputs #59231
Conversation
numpy has not been a dependency since 2012. apart from being unnecessary, numpy depends on openblas which fails to build on aarch64. wheel seems to be a dependency. without it "error: invalid command 'bdist_wheel'"
We need it at build time.
It is only used for the test suite.
It is no longer used at all.
@GrahamcOfBorg build tahoe-lafs |
Tahoe-lafs seems to build fine on the aarch64 Hydra machine: https://hydra.nixos.org/build/91870347 |
I'm sure of very little. But the build clearly fails in my environment. |
Maybe I should make it more clear that this build happens in the context of building an aarch64 sd-image? Could that make some difference? Like ... the normal/hydra build drags in the wheel dependency by accident somehow so the build works but without the explicit declaration it fails when the sd-image build fails to provide the dependency? I don't know, wildly guessing here. |
I wouldn't think so. I suggest you run |
Using nixpkgs-unstable channel. This seems to be at 19.09pre174594.0c0954781e2
I got a checkout of nixpkgs and ran this. It succeeds just by fetching from the binary cache. Not sure how to force it to try actually building locally. |
Cannot reproduce the failure on nixpkgs master@HEAD. |
@dotlambda, @exarkun do still want to include the cleanups from here? |
Yes, that would be nice. |
You can use |
Maybe I should suggest these cleanups for #59258 ? |
You can simply repon this PR or open a new one. Just remove |
This is no longer (was never? unclear) required.
Okay. Here's an update that only:
I verified that this builds (thus, check passes) but I didn't try running the software yet. |
I've now done a few basic manual tests of the output (the "tahoe" program) and it seems good. |
Maybe we should keep |
Nothing in misc ends up in output, nor does anything that does end up in output appear to reference numpy. Creating additional outputs for the misc tools might be sensible but I'm not interested in working on that as I've never yet had occasion to use anything from the misc directory. |
Alright, I'll merge this. If someone complains, this is still an easy fix. @GrahamcOfBorg build tahoe-lafs |
Motivation for this change
make tahoe-lafs build on aarch64
Things done
sandbox
innix.conf
on non-NixOS)./result/bin/
)nix-shell -p nix-review --run "nix-review wip"
nix path-info -S
before and after)