Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.nltk: 3.2.5 -> 3.4 #59204

Merged
merged 2 commits into from Apr 14, 2019
Merged

pythonPackages.nltk: 3.2.5 -> 3.4 #59204

merged 2 commits into from Apr 14, 2019

Conversation

couchemar
Copy link
Contributor

Motivation for this change

Update to the most recent version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@couchemar couchemar requested a review from FRidh as a code owner April 9, 2019 09:25
@lheckemann
Copy link
Member

lheckemann commented Apr 10, 2019 •
edited

@GrahamcOfBorg build python3Packages.nltk

again!

@dotlambda dotlambda changed the title nltk: 3.2.5 -> 3.4 pythonPackages.nltk: 3.2.5 -> 3.4 Apr 10, 2019
dotlambda
dotlambda requested changes Apr 10, 2019
View reviewed changes
pkgs/development/python-modules/nltk/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/nltk/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/nltk/default.nix Outdated Show resolved Hide resolved
@couchemar
Copy link
Contributor Author

@dotlambda ed004dc check fixes

@matthiasbeyer
Copy link
Contributor

Nice. Now you can rebase-squash and expand the commit message to tell what you did!

Awesome work!

matthiasbeyer
matthiasbeyer approved these changes Apr 12, 2019
View reviewed changes
Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch looks good to me.

@couchemar
pythonPackages.nltk: 3.2.5 -> 3.4
f6ff477 
Add optional dependency "singledispatch" for python 2.7.
Remove "disabled" attribute from derivation.
@lheckemann
Copy link
Member

@GrahamcOfBorg build python3Packages.nltk

dotlambda
dotlambda requested changes Apr 13, 2019
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor nitpick

pkgs/development/python-modules/nltk/default.nix Outdated Show resolved Hide resolved
@dotlambda @couchemar
Update pkgs/development/python-modules/nltk/default.nix
6dee8a1 
Co-Authored-By: couchemar <couchemar@yandex.ru>
@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.nltk python3.pkgs.nltk

@dotlambda dotlambda merged commit 2e9e631 into NixOS:master Apr 14, 2019
@couchemar couchemar deleted the nltk-3.4 branch April 14, 2019 16:05
lsix pushed a commit to lsix/nixpkgs that referenced this pull request Aug 22, 2019
@couchemar @lsix
pythonPackages.nltk: 3.2.5 -> 3.4 (NixOS#59204)
aa5608f 
Add optional dependency "singledispatch" for python 2.7.
Remove "disabled" attribute from derivation.

(cherry picked from commit 2e9e631)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@lheckemann lheckemann Awaiting requested review from lheckemann

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@couchemar @lheckemann @matthiasbeyer @dotlambda @GrahamcOfBorg