Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lobster: init #59128

Closed
wants to merge 2 commits into from
Closed

lobster: init #59128

wants to merge 2 commits into from

Conversation

jacereda
Copy link
Contributor

@jacereda jacereda commented Apr 7, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@etu etu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some notes and also, do you want to maintain this package?

pkgs/development/interpreters/lobster/default.nix Outdated Show resolved Hide resolved
pkgs/development/interpreters/lobster/default.nix Outdated Show resolved Hide resolved
pkgs/development/interpreters/lobster/default.nix Outdated Show resolved Hide resolved
pkgs/development/interpreters/lobster/default.nix Outdated Show resolved Hide resolved
pkgs/development/interpreters/lobster/default.nix Outdated Show resolved Hide resolved
@jacereda
Copy link
Contributor Author

jacereda commented Apr 10, 2019

I might maintain the package at some point, for now I'm still exploring the language.

@Lassulus
Copy link
Member

Lassulus commented Oct 2, 2019

I tested this, it works. would be happy if you would also maintain it?

@fgaz
Copy link
Member

fgaz commented Jan 21, 2020

Current HEAD makes it easier to package this. I have a working package (on linux, but I see from this pr that darwin just needs some more deps) here: https://github.com/fgaz/nur-packages/blob/3dfb84a7b8660816ae679f20606bb2d77754b167/pkgs/lobster/default.nix

@fgaz fgaz mentioned this pull request Jan 26, 2020
10 tasks
@fgaz
Copy link
Member

fgaz commented Jan 26, 2020

I added myself as a maintainer in #78562, even though I cannot directly test on darwin

@stale
Copy link

stale bot commented Jul 24, 2020

Hello, I'm a bot and I thank you in the name of the community for your contributions.

Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:

If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.

If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.

If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.

Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants