Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.django_2_2: init at 2.2 #59212

Merged
merged 1 commit into from May 23, 2019
Merged

python3Packages.django_2_2: init at 2.2 #59212

merged 1 commit into from May 23, 2019

Conversation

lsix
Copy link
Member

@lsix lsix commented Apr 9, 2019

Motivation for this change

This introduces Django-2.2, the new LTR version of django. As it only
supports python3, python2 will continue to use django_1_11 as LTR
version as it is still supported until 2020.

We can decide to continue with 1.11 as main version of django for some time, but I prefer to pick the last stable one.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lsix lsix requested a review from FRidh as a code owner April 9, 2019 13:47
dotlambda
dotlambda requested changes Apr 10, 2019
View reviewed changes
pkgs/development/python-modules/django/2_2.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/django/2_2.nix Outdated Show resolved Hide resolved
pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
@lsix lsix force-pushed the add_django_2_2 branch 2 times, most recently from 72c3a3f to 3e65830 Compare May 20, 2019 09:36
@lsix
python3Packages.django_2_2: init at 2.2.1
d2de73f 
This introduces Django-2.2, the new LTR version of django.

For the time being, django-1.11 continues to be LTR in nixpkgs
django-2.2 is introduced to prepare the migration.
@lsix
Copy link
Member Author

lsix commented May 20, 2019

@dotlambda I have addressed your review. Sorry for such a long delay.

For the time being, I keep django-1.11 as main version, so we can introduce 2.2 and later migrate the default version of django used.

@lsix lsix merged commit 219a99f into NixOS:master May 23, 2019
@lsix lsix deleted the add_django_2_2 branch August 22, 2019 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lsix @dotlambda @GrahamcOfBorg