Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 1b61f959bebc
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: f2082ef1dad9
Choose a head ref
  • 1 commit
  • 3 files changed
  • 1 contributor

Commits on Apr 8, 2019

  1. qt5.qtwebengine: fail properly

    QtWebEngine's build system is setup to perform certain platform checks
    (see mkspecs/features/platform.prf). But a failed check will not cause
    configuration phase to fail, but instead it configures no build targets.
    So in such case the build will successfully perform build and install
    phases. An empty output directories will are produced and the build
    succeeds.
    
    This patches qtwebengine qmake files to properly fail during
    configuration phase.
    
    This doesn't touch qt56 as it doesn't have this mechanism.
    
    (cherry picked from commit 3e3e391)
    veprbl committed Apr 8, 2019
    Copy the full SHA
    f2082ef View commit details
    Browse the repository at this point in the history