Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.cntk: mark as broken with python 3.7 #59178

Merged
merged 2 commits into from Apr 10, 2019
Merged

pythonPackages.cntk: mark as broken with python 3.7 #59178

merged 2 commits into from Apr 10, 2019

Conversation

markuskowa
Copy link
Member

Motivation for this change

The CNTK python module seems to be broken since November 2018 (does not recognize swig).
Mark it as broken.

Needs back port to 19.03 (#56826)

CC @costrouc @abbradar

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@markuskowa markuskowa requested a review from FRidh as a code owner April 8, 2019 12:40
@dotlambda
Copy link
Member

Since #54182, swig needs to be in nativeBuildInputs.

@markuskowa
Copy link
Member Author

@dotlambda thanks for the tip. It does find swig now but fails at later stage with a different error.

@dotlambda
Copy link
Member

It fails with

unable to execute 'mpic++': No such file or directory

because openmpi isn't in nativeBuildInputs. However, I'm not sure if that one should remain in buildInputs too.

@markuskowa
Copy link
Member Author

markuskowa commented Apr 8, 2019 •
edited by dotlambda

OK, that solves the mpic++ error but then we get the next error:

ImportError: cannot import name 'GenericMeta' from 'typing'

openmpi should probably remain in buildInputs since it is also a run time dependency.

@dotlambda
Copy link
Member

ImportError: cannot import name 'GenericMeta' from 'typing'

See hsolbrig/PyShEx#17. I guess that needs to be fixed upstream by ctnk.

@markuskowa
Copy link
Member Author

I restricted the broken attribute to python 3.7

@GrahamcOfBorg build python27Packages.cntk
@GrahamcOfBorg build python36Packages.cntk

@markuskowa markuskowa changed the title pythonPackages.cntk: mark as broken pythonPackages.cntk: mark as broken with python 3.7 Apr 9, 2019
@dotlambda dotlambda merged commit fd8ff46 into NixOS:master Apr 10, 2019
@dotlambda
Copy link
Member

I restricted the broken attribute to python 3.7

Perfect!

@markuskowa markuskowa deleted the fix-cntk branch April 10, 2019 08:38
@markuskowa
Copy link
Member Author

Thanks for the fixes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@markuskowa @dotlambda @GrahamcOfBorg