Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libsodium: 1.0.16 -> 1.0.17 #59233

Merged
merged 1 commit into from Apr 16, 2019
Merged

libsodium: 1.0.16 -> 1.0.17 #59233

merged 1 commit into from Apr 16, 2019

Conversation

dnaq
Copy link
Contributor

@dnaq dnaq commented Apr 9, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@7c6f434c
Copy link
Member

@GrahamcOfBorg build nix nixUnstable toxvpn minisign dovecot powerdns

@matthiasbeyer matthiasbeyer mentioned this pull request Apr 10, 2019
Closed
10 tasks
@7c6f434c
Copy link
Member

Hm. Dovecot builds on Hydra on macOS, but not on ofBorg with this update. I wonder if the «portability improvements» mentioned in https://github.com/jedisct1/libsodium/releases are related.

@xeji xeji mentioned this pull request Apr 10, 2019
Closed
@7c6f434c
Copy link
Member

@GrahamcOfBorg build dovecot

@strager
Copy link
Contributor

strager commented Apr 15, 2019 •
edited

OfBorg's latest build of dovecot for this PR failed because of #59450.

@7c6f434c
Copy link
Member

Thanks for the link. Previous error was more relevant. But now the fix is merged, as I can see…

@GrahamcOfBorg build nix nixUnstable toxvpn minisign dovecot powerdns

@7c6f434c 7c6f434c mentioned this pull request Apr 15, 2019
Closed
@strager
Copy link
Contributor

strager commented Apr 16, 2019

On my macOS 10.12 machine, dovecot builds but doesn't run properly (both with this PR and without this PR):

$ # With PR (b050097edfc54cf7c2b5bd655b4edfdfb2e98757 merged with 7303aad9855482ae801834bf76814df507228cb0):
$ nix-review pr -p nix -p nixUnstable -p toxvpn -p minisign -p dovecot -p powerdns 59233
[nix-shell:~/.cache/nix-review/pr-59233]$ ./results/dovecot/bin/dovecot
Fatal: Error reading configuration: stat(/etc/dovecot/dovecot.conf) failed: No such file or directory

$ # Without PR (098cf3b348a282321b5f117cf22d71cf04ad12d9):
$ nix-build -A dovecot
/nix/store/krw65ljy98302gf60kh5drpzf7issm0n-dovecot-2.3.5.1
$ /nix/store/krw65ljy98302gf60kh5drpzf7issm0n-dovecot-2.3.5.1/bin/dovecot
Fatal: Error reading configuration: stat(/etc/dovecot/dovecot.conf) failed: No such file or directory

@7c6f434c
Copy link
Member

That's normal for dovecot if you don't tell it where to obtain the configuration file. I guess it all should be fine then.

@7c6f434c 7c6f434c merged commit 5655be5 into NixOS:master Apr 16, 2019
@7c6f434c
Copy link
Member

Oops, I thought it is towards staging

@7c6f434c
Copy link
Member

Reverted/pushed to staging, sorry

7c6f434c added a commit that referenced this pull request Apr 16, 2019
@7c6f434c
Merge pull request #59233 from dnaq/libsodium-1.0.17
1acacaa 
libsodium: 1.0.16 -> 1.0.17
(cherry picked from commit 5655be5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dnaq @7c6f434c @strager @matthiasbeyer @GrahamcOfBorg