Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpc: update version and build shared libs #59232

Merged
merged 2 commits into from Apr 24, 2019
Merged

grpc: update version and build shared libs #59232

merged 2 commits into from Apr 24, 2019

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Apr 9, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh FRidh requested a review from LnL7 April 9, 2019 19:38
andrew-d
andrew-d suggested changes Apr 10, 2019
View reviewed changes
Copy link
Contributor

@andrew-d andrew-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a typo!

pkgs/development/libraries/grpc/default.nix Outdated Show resolved Hide resolved
@FRidh FRidh changed the title grpc: update version and build shared libs instead of static grpc: update version and build shared libs Apr 12, 2019
@c0bw3b c0bw3b merged commit bd44e3a into NixOS:master Apr 24, 2019
@c0bw3b c0bw3b mentioned this pull request Apr 26, 2019
Merged
10 tasks
@FRidh FRidh deleted the grpc branch April 27, 2019 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-d andrew-d andrew-d requested changes

@LnL7 LnL7 Awaiting requested review from LnL7

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@FRidh @andrew-d @c0bw3b @GrahamcOfBorg