Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macdylibbundler: init #59173

Merged
merged 2 commits into from Apr 9, 2019
Merged

macdylibbundler: init #59173

merged 2 commits into from Apr 9, 2019

Conversation

nomeata
Copy link
Contributor

@nomeata nomeata commented Apr 8, 2019

Motivation for this change

which I found useful to make self-contained releases of binaries built
on osx.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

whihc I found useful to make self-contained releases of binaries built
on osx.
@nomeata
Copy link
Contributor Author

nomeata commented Apr 8, 2019

It builds on non-osx systems, but is less useful there because it wants otool in the PATH. Not sure if otool can be packaged, or if this package should be restricted to OSX then.

@matthewbauer
Copy link
Member

darwin.cctools contains otool. I think it makes sense to wrap it. We can definitely get it to work on linux.

@matthewbauer
Copy link
Member

/cc @Ericson2314

@nomeata
Copy link
Contributor Author

nomeata commented Apr 8, 2019

BTW, I have no version fields; is that ok for a package installed from GitHub where upstream does not define versions?

@matthewbauer
Copy link
Member

I think you should use the date the commit was made. So version = "20180825"

@matthewbauer matthewbauer merged commit 610f73f into NixOS:master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants