brackets: add missing dependencies. #59195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libexpat and libXdamage seems to be required for brackets to run
worldofpeace
approved these changes
Apr 9, 2019
There was a problem hiding this comment.
Builds and executes for me 👍
I'm sorry that's my first contribution and despite NixOS being my daily driver I'm really not familiar with packaging process and builds.
If you wanted to test this change without nix-env, one could perform
nix-build -A brackets
./result/bin/brackets
With cwd being the checkout.
Though testing applications with nix-env is a good thing to do also.
(you can nix-env -i on the symlink too)
More info here:
- https://nixos.wiki/wiki/Nixpkgs/Create_and_debug_packages
- https://nixos.org/nixpkgs/manual/#chap-submitting-changes
(maybe you've already read)
|
Thanks for taking the time to contribute @damien-biasotto ✨ |
|
backported in 095bc4f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libexpatandlibXdamageseems to be required for brackets to run. Fixes #55810.I'm sorry that's my first contribution and despite NixOS being my daily driver I'm really not familiar with packaging process and builds.
So I tested my changes using
nix-env -f /home/damien/Repositories/fork-nixpkgs -i bracketsand it runs.I'm at work so i didn't take time to run in a sandbox mode :(
Motivation for this change
Make brackets run again.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)