Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.03] binutils-wrapper: Try to avoid adding unnecessary -L flags #59216

Closed

Conversation

matthewbauer
Copy link
Member

We should have backported this to 18.03 but it got lost in the merges. This should fix most cases of the Argument list too long bug.

(cherry picked from commit f375825)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

(cherry picked from commit f375825)
Signed-off-by: Domen Kožar <domen@dev.si>
@matthewbauer matthewbauer changed the title binutils-wrapper: Try to avoid adding unnecessary -L flags [18.03] binutils-wrapper: Try to avoid adding unnecessary -L flags Apr 9, 2019
@disassembler
Copy link
Member

18.03 is no longer supported, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants