Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose prometheus generic builder. #59175

Merged
merged 2 commits into from Apr 8, 2019
Merged

Expose prometheus generic builder. #59175

merged 2 commits into from Apr 8, 2019

Conversation

jbgi
Copy link
Contributor

@jbgi jbgi commented Apr 8, 2019

Motivation for this change

So that people can easily try newer prometheus versions in overlays:

 self: super: {
   prometheus_2 = (super.callPackage <nixpkgs/pkgs/servers/monitoring/prometheus> {}).generic {
     version = "2.8.1";
     sha256 = "0x8w0qdh4lcf19nmdlhvgzpy08c2a932d3k49cjwhi5npcsf858n";
     doCheck = false;
   };
 }
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jbgi
Expose prometheus generic builder.
670359e 
 So that people can easily try newer prometheus version
 in overlays:

 self: super: {
   prometheus_2 = (super.callPackage <nixpkgs/pkgs/servers/monitoring/prometheus> {}).generic {
     version = "2.8.1";
     sha256 = "0x8w0qdh4lcf19nmdlhvgzpy08c2a932d3k49cjwhi5npcsf858n";
     doCheck = false;
   };
 }
@basvandijk
Copy link
Member

Maybe rename generic to buildPrometheus to give it a less generic name.

@basvandijk
Copy link
Member

BTW I just tested the prometheus2 test on prometheus-2.8.1 and that finishes successfully. Will push a PR soon.

@basvandijk
Copy link
Member

See: #59182. I'll merge that as soon as the checks complete.

@basvandijk
prometheus: rename the generic function to buildPrometheus
b6fdd1a 
Since the `generic` function is now exported it should have a less
generic name, pun intended.
@basvandijk
Copy link
Member

I just pushed the rename myself. Will merge after the checks complete.

@jbgi
Copy link
Contributor Author

jbgi commented Apr 8, 2019 •
edited

@basvandijk thanks, for some reasons the checks did not pass on my machine when I tried to build 2.8.1, which was the original reason for this PR...

@basvandijk basvandijk merged commit 65fa918 into NixOS:master Apr 8, 2019
@basvandijk basvandijk mentioned this pull request Apr 10, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jbgi @basvandijk @GrahamcOfBorg