Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rhc: remove #59143

Merged
merged 1 commit into from Apr 9, 2019
Merged

rhc: remove #59143

merged 1 commit into from Apr 9, 2019

Conversation

manveru
Copy link
Contributor

@manveru manveru commented Apr 7, 2019 •
edited

Motivation for this change

This application is deprecated since 2016 and won't build on current Ruby versions: https://github.com/openshift/rhc

That's why I think it's safe to remove, since it's been marked as broken in February 2018.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl
Copy link
Member

veprbl commented Apr 7, 2019

cc @Szczyp

worldofpeace
worldofpeace approved these changes Apr 8, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , we should remove deprecated software whenever we can do so feasibly.

@Ma27
Copy link
Member

Ma27 commented Apr 8, 2019

With NIXPKGS_ALLOW_BROKEN=1 it still builds for me (I get a lot of deprecations warnings with Ruby 2.5 though), so I suggest that we keep the attribute in all-packages.nix for now:

{
  # ...
  rhc = throw ''
    `rhc` has been removed as it's marked as broken since 2018-02 and 
    officially abandoned by upstream.
  '';
}

@worldofpeace
Copy link
Contributor

With NIXPKGS_ALLOW_BROKEN=1 it still builds for me (I get a lot of deprecations warnings with Ruby 2.5 though), so I suggest that we keep the attribute in all-packages.nix for now:

{
  # ...
  rhc = throw ''
    `rhc` has been removed as it's marked as broken since 2018-02 and 
    officially abandoned by upstream.
  '';
}

Yeah, having a message would be helpful. Though I think that should be in aliases.nix.

@manveru
Copy link
Contributor Author

manveru commented Apr 9, 2019

I added the alias, tried to keep it as short as the other ones. Does this look OK for you?

@Ma27 Ma27 merged commit 3528e6b into NixOS:master Apr 9, 2019
@Ma27
Copy link
Member

Ma27 commented Apr 9, 2019

@manveru thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@manveru @veprbl @Ma27 @worldofpeace @GrahamcOfBorg