Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frab: 2016-12-28 -> 2019-03-22 #59142

Closed
wants to merge 1 commit into from
Closed

frab: 2016-12-28 -> 2019-03-22 #59142

wants to merge 1 commit into from

Conversation

manveru
Copy link
Contributor

@manveru manveru commented Apr 7, 2019 •
edited

Motivation for this change

This has been marked broken for too long.

I went ahead and refactored the service a bit to current ruby standards.
Also added a test that should make sure future breakage is found earlier and I can notice when it happens.

I don't personally use frab, but I also can't stand broken ruby apps in nixpkgs, so I'd appreciate if someone who wants to use it could give it a quick test-drive.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@manveru manveru requested a review from infinisil as a code owner April 7, 2019 23:19
@manveru
Copy link
Contributor Author

manveru commented Apr 7, 2019

Also, pinging @fpletz since he did the initial package.

@manveru manveru mentioned this pull request May 3, 2019
Open
27 tasks
@c0bw3b
Copy link
Contributor

c0bw3b commented May 4, 2019

@GrahamcOfBorg build frab

@0x4A6F
Copy link
Member

0x4A6F commented Nov 8, 2019

@manveru Please rebase.

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 3, 2020
@ajs124 ajs124 mentioned this pull request Dec 11, 2020
Merged
10 tasks
@Mic92
Copy link
Member

Mic92 commented Dec 11, 2020

We decided to remove this package #106601

@Mic92 Mic92 closed this Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@manveru @c0bw3b @0x4A6F @Mic92 @ryantm @GrahamcOfBorg