Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages: add language-server for bash, vue, html and css #59184

Merged
merged 1 commit into from May 10, 2019
Merged

nodePackages: add language-server for bash, vue, html and css #59184

merged 1 commit into from May 10, 2019

Conversation

bricewge
Copy link
Contributor

@bricewge bricewge commented Apr 8, 2019

Motivation for this change

This PR add language-servers for bash, vue, html and css.

Related with #41399

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthew-piziak
Copy link
Contributor

Hi there! We're going to try a different workflow for nodePackages. Right now there are a number of PRs targeting nodePackages, and the churn makes it hard for you to keep your generated .nix files free of merge conflicts.

Could you please remove your generated changes, and just leave your changes in the .json file? That will make it easy to update, review, and merge. Then later this week we are going to generate everybody's nodePackages changes at once.

Thank you!

cc: @ryantm

Feel free to join us in Freenode's #nixos if you have questions about this.

@bricewge
Copy link
Contributor Author

It is done.

@ryantm ryantm merged commit 99a59cf into NixOS:master May 10, 2019
@dotlambda dotlambda mentioned this pull request Aug 21, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bricewge @matthew-piziak @ryantm @GrahamcOfBorg