New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
brook: init at 20190401 #59201
brook: init at 20190401 #59201
Conversation
@GrahamcOfBorg build brook |
Build fails on MacOS (although upstream says it's supported). Please either fix the darwin build (unfortunately I cannot help with that, don't have a Mac) or set |
@xeji Thanks for the review! |
@GrahamcOfBorg build brook |
@GrahamcOfBorg build brook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, looks good now.
Motivation for this change
Brook is a cross-platform(Linux/MacOS/Windows/Android/iOS) proxy/vpn software
https://github.com/txthinking/brook
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)