Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brook: init at 20190401 #59201

Merged
merged 1 commit into from Apr 10, 2019
Merged

brook: init at 20190401 #59201

merged 1 commit into from Apr 10, 2019

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Apr 9, 2019 •
edited

Motivation for this change

Brook is a cross-platform(Linux/MacOS/Windows/Android/iOS) proxy/vpn software

https://github.com/txthinking/brook

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xrelkd xrelkd changed the title brook: init at v20190401 brook: init at 20190401 Apr 9, 2019
@xeji
Copy link
Contributor

xeji commented Apr 10, 2019

@GrahamcOfBorg build brook

@xeji
Copy link
Contributor

xeji commented Apr 10, 2019

Build fails on MacOS (although upstream says it's supported). Please either fix the darwin build (unfortunately I cannot help with that, don't have a Mac) or set platforms = platforms.linux; until someone else does.

@xrelkd
Copy link
Contributor Author

xrelkd commented Apr 10, 2019

@xeji Thanks for the review!
I don't have Mac either, so I just set platforms = platforms.linux;.
I really appreciate your patience in reviewing all my PR.

@xeji
Copy link
Contributor

xeji commented Apr 10, 2019

@GrahamcOfBorg build brook

@xeji
Copy link
Contributor

xeji commented Apr 10, 2019

@GrahamcOfBorg build brook

xeji
xeji approved these changes Apr 10, 2019
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good now.

@xeji xeji merged commit fc16035 into NixOS:master Apr 10, 2019
@xrelkd xrelkd deleted the brook branch April 10, 2019 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xrelkd @xeji @GrahamcOfBorg