Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openjdk11: Update source hashes for aarch64 #60224

Merged
merged 2 commits into from Apr 28, 2019
Merged

openjdk11: Update source hashes for aarch64 #60224

merged 2 commits into from Apr 28, 2019

Conversation

JohnAZoidberg
Copy link
Member

Motivation for this change

Seems like they replaced the release file.
See: #59179 (comment)
and: https://hydra.nixos.org/eval/1516026?filter=jdk&compare=1516009&full=

I haven't tested it as I don't have an aarch64 build machine and we don't have anything to bootstrap the cross compilation.
But I updated with pkgs/development/compilers/adoptopenjdk-bin/generate-sources.py so it should be reasonably safe.

Question: Why does the jre on aarch64 default to adoptopenjdk while the jdk defaults to Oracle? See: https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/all-packages.nix#L7459

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@JohnAZoidberg
adoptopenjdk-jre-bin: Update source hashes for aarch64
b67f792 
Seems like they replaced the release file.
Updated with
pkgs/development/compilers/adoptopenjdk-bin/generate-sources.py
so should be reasonably safe.
@JohnAZoidberg
adoptopenjdk-bin: Update source hashes for aarch64
069e1a7 
Seems like they replaced the release file.
Updated with
pkgs/development/compilers/adoptopenjdk-bin/generate-sources.py
so should be reasonably safe.
@aanderse aanderse mentioned this pull request Apr 26, 2019
Merged
10 tasks
@aanderse
Copy link
Member

@GrahamcOfBorg build adoptopenjdk-bin
@GrahamcOfBorg build adoptopenjdk-jre-bin

@taku0 taku0 mentioned this pull request Apr 27, 2019
Closed
10 tasks
@aanderse aanderse merged commit cad1a82 into NixOS:master Apr 28, 2019
@aanderse
Copy link
Member

Thanks @JohnAZoidberg!

@JohnAZoidberg JohnAZoidberg deleted the fix-jre11 branch April 28, 2019 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JohnAZoidberg @aanderse