mousetweaks: init at 3.32.0 #60176

JohnAZoidberg · 2019-04-24T18:32:32Z

Motivation for this change

We should have more accessibility programs.

Runs fine but I haven't tested with Gnome so I don't know if it does the
right thing. So I guess it's WIP.
I'd be glad if somebody tried it on Gnome :)

Solves #39509

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Assured whether relevant documentation is up to date
Fits CONTRIBUTING.md.

jtojnar · 2019-04-24T18:50:00Z

This will not work on GNOME under Wayland. I heard something about it being rewritten as a part of Mutter (GNOME’s WM) ~~but cannot find the reference now.~~

Edit: https://gitlab.gnome.org/GNOME/mutter/merge_requests/512 https://gitlab.gnome.org/GNOME/mutter/issues/42

JohnAZoidberg · 2019-04-24T19:14:23Z

Hmmmm, I'll look into it.
Also I created the directory pkgs/applications/accessibility I think we should move some tools there to have them sorted better. (e.g. orca is in pkgs/misc)

JohnAZoidberg · 2019-04-24T19:24:45Z

Maybe I should move this under the gnome3 attribute if it only works on Gnome.

jtojnar · 2019-04-24T19:34:50Z

I tested mousetweaks --dwell in elementary and it still works so top-level attribute is fine. I am actually trying to get rid of gnome3 attribute set.

pkgs/applications/accessibility/mousetweaks/default.nix

jtojnar · 2019-04-24T19:38:25Z

pkgs/applications/accessibility/mousetweaks/default.nix

+    license = licenses.gpl2;
+    platforms = platforms.all;
+    maintainers = [ maintainers.johnazoidberg ];
+    repositories.git = https://gitlab.gnome.org/GNOME/mousetweaks;


I do not think this does anything.

I saw it on some other derivations and thought it couldn't hurt.
I'm not sure it does anything either 🤷‍♂️

72 derivations have it so it's at least an unwritten convention. Doesn't seem to be used right now but might be useful in the future.

I suspect it comes from update walker, an old update system nobody uses.

No reference to this in update walker. According to 452b25b it is used by some @Phreedom’s tool, possibly https://github.com/Phreedom/nixpkgs-monitor, which refers to it in its source code.

Hmm, yeah I understand Eelco's concern but since there are already a lot of packages with it I think we can continue for packages that the repository is neither the homepage nor the source.

Oh, I did not even notice the comments.

Most of GNOME's wiki pages have a mention of the git repository, and even in this case where it's an old
url https://git.gnome.org/browse/mousetweaks it still redirects to GitLab.

There's not a lot of references to this attribute and I don't even see it documented anywhere. I'd say it's safe to not
use it, though I do see a place for it being useful as you mentioned @JohnAZoidberg.

Well it is kind of formal, it's been a part of the valid meta attributes for quite a while.
@copumpkin added it here: 1a4ca22#diff-3c8a88619c3ca3d61eb0ce8794d9bb74R228
He added the check probably after realizing that lots of people started to use it.

pkgs/applications/accessibility/mousetweaks/default.nix

worldofpeace · 2019-04-24T19:45:20Z

😏 https://gitlab.gnome.org/GNOME/gnome-build-meta/merge_requests/269

jtojnar · 2019-04-24T19:55:55Z

Yeah, https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/474 is the MR I had in mind.

I can confirm this works in GNOME Shell running on Xorg (In Control Center under Universal Access enable Click Assist).

We may want to patch https://gitlab.gnome.org/GNOME/gnome-settings-daemon/blob/725d1e53fd656e1039c8da02ba0dbfd3db93b3c1/plugins/mouse/gsd-mouse-manager.c#L119, as without mousekeys being on PATH, the Click assist just immediately switches itself off with the only error being logged in journal.

Given that this is useful for other Xorg based desktops (even though it might need to be controlled through CLI arguments), I would still like to merge this. It is not like we are removing Xorg anytime soon, and those relying on accessibility features still depend on it anyway.

worldofpeace · 2019-04-24T20:20:34Z

I tested mousetweaks --dwell in elementary and it still works so top-level attribute is fine.

I can confirm this works in GNOME Shell running on Xorg

Hmm does jtojnar switch between these effortlessly 😁

We may want to patch https://gitlab.gnome.org/GNOME/gnome-settings-daemon/blob/725d1e53fd656e1039c8da02ba0dbfd3db93b3c1/plugins/mouse/gsd-mouse-manager.c#L119, as without mousekeys being on PATH, the typing access just immediately switches itself off with the only error being logged in journal.

Sure, we can eat the runtime dep.

Given that this is useful for other Xorg based desktops (even though it might need to be controlled through CLI arguments), I would still like to merge this. It is not like we are removing Xorg anytime soon, and those relying on accessibility features still depend on it anyway.

Right, surprised it wasn't packaged already anyway.

jtojnar · 2019-04-24T20:34:03Z

Hmm does jtojnar switch between these effortlessly 😁

I have elementary and some other VM definitions on hand, so I just run

nixos-rebuild build-vm -I nixpkgs=$HOME/Projects/nixpkgs -I nixos-config=../nix-playground/elementary.nix
env QEMU_NET_OPTS="hostfwd=tcp::2222-:22" ./result/bin/run-*-vm

and roll 🚶‍♂️

Right, surprised it wasn't packaged already anyway.

Yeah, I was lazy and it was not very high in my queue since I was not sure what it actually does.

worldofpeace · 2019-04-24T20:41:29Z

I have elementary and some other VM definitions on hand, so I just run

nixos-rebuild build-vm -I nixpkgs=$HOME/Projects/nixpkgs -I nixos-config=../nix-playground/elementary.nix
env QEMU_NET_OPTS="hostfwd=tcp::2222-:22" ./result/bin/run-*-vm

huh, I tend to keep a repo of configurations and just use an alias to build them when it's in the working directory.

Also looks like they even ship this tool
https://github.com/elementary/metapackages/blob/f27df798111e207f056a7a3d63eaf495aa0d34a7/desktop-recommends-amd64#L133

Yeah, I was lazy and it was not very high in my queue since I was not sure what it actually does.

Same there, they shipped it so I almost packaged it. But didn't know what it was for.

JohnAZoidberg · 2019-04-24T21:14:51Z

Thanks for the feedback!
It doesn't look unmaintained, it's been getting a few commits until 4 weeks ago.
Seems that MR is the only one that mentions it's deprecated - but the replacement hasn't been merged yet.

We may want to patch gitlab.gnome.org/GNOME/gnome-settings-daemon/blob/725d1e53fd656e1039c8da02ba0dbfd3db93b3c1/plugins/mouse/gsd-mouse-manager.c#L119, as without mousekeys being on PATH, the typing access just immediately switches itself off with the only error being logged in journal.

But isn't mousekeys on the PATH? Or how did you install it for use with GNOME?

jtojnar · 2019-04-24T21:36:22Z

Looked into if onboard should depend on mousetweaks. First I was confused that it depends on the old settings schemas org.gnome.Mousetweaks but apparently, it is only used for determining whether mousekeys are installed:
https://bazaar.launchpad.net/~onboard/onboard/trunk/view/head:/Onboard/ClickSimulator.py?start_revid=2295#L443

I suggest adding it to buildInputs of onboard.

And we might want to patch https://bazaar.launchpad.net/~onboard/onboard/trunk/view/head:/Onboard/ClickSimulator.py?start_revid=2295#L482

jtojnar · 2019-04-24T21:39:21Z

Cannot find any code path where orca depends on mousetweaks.

JohnAZoidberg · 2019-04-24T22:37:55Z

I patched both locations.
But I'm not happy with the sed solution. It just silently fails when the code changes - or might even screw with new code.

Is there a way to write a patch file that I can interpolate a nix-store path into? I remember seeing something with @@var@@.

jtojnar · 2019-04-24T22:55:06Z

You can use patch with substituteAll:

nixpkgs/pkgs/desktops/gnome-3/core/gnome-control-center/default.nix

Lines 39 to 47 in 12b82b1

    
           patches = [ 
        
             (substituteAll { 
        
               src = ./paths.patch; 
        
               gcm = gnome-color-manager; 
        
               gnome_desktop = gnome-desktop; 
        
               inherit glibc libgnomekbd tzdata; 
        
               inherit cups networkmanagerapplet; 
        
             }) 
        
           ];

JohnAZoidberg · 2019-04-24T23:13:15Z

Thanks! Now it's using that.

pkgs/applications/misc/onboard/default.nix

worldofpeace · 2019-04-28T18:19:30Z

Things done in the force push

Dropped repositories.git in mousetweaks. (mousetweaks: init at 3.32.0 #60176 (comment))
Squashed commits, commit msg cleanup
Added hardcode patch for pantheon's gnome-settings-daemon
mousetweaks platforms should be linux

worldofpeace

Think it's ready for merge 👍

Appears resolved by author from my discernment

Solves NixOS#39509

See: NixOS#60176 (comment)

worldofpeace · 2019-04-28T18:26:00Z

Thank you @JohnAZoidberg for your contribution and being so quick to respond to changes ✨

JohnAZoidberg · 2019-04-28T19:03:24Z

Thanks for your thorough review!

JohnAZoidberg force-pushed the mousetweaks branch from cc6e335 to b32b632 Compare April 24, 2019 18:33

ofborg bot added 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Apr 24, 2019

jtojnar added 6.topic: accessibility 6.topic: GNOME GNOME desktop environment and its underlying platform labels Apr 24, 2019

JohnAZoidberg force-pushed the mousetweaks branch from b32b632 to 11ca4a3 Compare April 24, 2019 19:27

ofborg bot removed the 6.topic: GNOME GNOME desktop environment and its underlying platform label Apr 24, 2019

jtojnar previously requested changes Apr 24, 2019

View reviewed changes

ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Apr 24, 2019

ofborg bot requested review from worldofpeace, jtojnar and hedning April 24, 2019 22:53

ofborg bot added 10.rebuild-linux: 11-100 and removed 10.rebuild-linux: 1-10 labels Apr 24, 2019

JohnAZoidberg force-pushed the mousetweaks branch from 05aee72 to 38b3206 Compare April 24, 2019 23:11

worldofpeace reviewed Apr 25, 2019

View reviewed changes

pkgs/applications/misc/onboard/default.nix Show resolved Hide resolved

JohnAZoidberg force-pushed the mousetweaks branch from 38b3206 to 7bf43ac Compare April 25, 2019 09:17

ofborg bot requested a review from worldofpeace April 25, 2019 09:33

worldofpeace force-pushed the mousetweaks branch from 7bf43ac to 6d4aa51 Compare April 28, 2019 18:17

worldofpeace approved these changes Apr 28, 2019

View reviewed changes

ofborg bot added the 6.topic: pantheon The Pantheon desktop environment label Apr 28, 2019

JohnAZoidberg and others added 4 commits April 28, 2019 14:23

mousetweaks: init at 3.32.0

08588e7

Solves NixOS#39509

onboard: Depend on mousetweaks

9da62cb

gnome3.gnome-settings-daemon: Use absolute path of mousetweaks

aa7a952

See: NixOS#60176 (comment)

pantheon.elementary-settings-daemon: Use absolute path of mousetweaks

8ffcfdd

worldofpeace force-pushed the mousetweaks branch from 6d4aa51 to 8ffcfdd Compare April 28, 2019 18:23

worldofpeace merged commit 5f14e83 into NixOS:master Apr 28, 2019

ofborg bot requested a review from worldofpeace April 28, 2019 18:33

JohnAZoidberg deleted the mousetweaks branch April 28, 2019 19:03

JohnAZoidberg mentioned this pull request Apr 29, 2019

Package mousetweaks #39509

Closed

worldofpeace mentioned this pull request May 13, 2019

Justify and document use of repositories.git meta attribute or remove it #61435

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mousetweaks: init at 3.32.0 #60176

mousetweaks: init at 3.32.0 #60176

JohnAZoidberg commented Apr 24, 2019

jtojnar commented Apr 24, 2019 •

edited

JohnAZoidberg commented Apr 24, 2019

JohnAZoidberg commented Apr 24, 2019

jtojnar commented Apr 24, 2019

jtojnar Apr 24, 2019

JohnAZoidberg Apr 24, 2019

JohnAZoidberg Apr 24, 2019 •

edited

jtojnar Apr 24, 2019

jtojnar Apr 24, 2019

JohnAZoidberg Apr 24, 2019

jtojnar Apr 24, 2019

worldofpeace Apr 28, 2019

JohnAZoidberg Apr 28, 2019

worldofpeace commented Apr 24, 2019

jtojnar commented Apr 24, 2019 •

edited

worldofpeace commented Apr 24, 2019

jtojnar commented Apr 24, 2019

worldofpeace commented Apr 24, 2019

JohnAZoidberg commented Apr 24, 2019 •

edited

jtojnar commented Apr 24, 2019

jtojnar commented Apr 24, 2019

JohnAZoidberg commented Apr 24, 2019

jtojnar commented Apr 24, 2019

JohnAZoidberg commented Apr 24, 2019

worldofpeace commented Apr 28, 2019 •

edited

worldofpeace left a comment

worldofpeace commented Apr 28, 2019

JohnAZoidberg commented Apr 28, 2019

mousetweaks: init at 3.32.0 #60176

mousetweaks: init at 3.32.0 #60176

Conversation

JohnAZoidberg commented Apr 24, 2019

Motivation for this change

Things done

jtojnar commented Apr 24, 2019 • edited

JohnAZoidberg commented Apr 24, 2019

JohnAZoidberg commented Apr 24, 2019

jtojnar commented Apr 24, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JohnAZoidberg Apr 24, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

worldofpeace commented Apr 24, 2019

jtojnar commented Apr 24, 2019 • edited

worldofpeace commented Apr 24, 2019

jtojnar commented Apr 24, 2019

worldofpeace commented Apr 24, 2019

JohnAZoidberg commented Apr 24, 2019 • edited

jtojnar commented Apr 24, 2019

jtojnar commented Apr 24, 2019

JohnAZoidberg commented Apr 24, 2019

jtojnar commented Apr 24, 2019

JohnAZoidberg commented Apr 24, 2019

worldofpeace commented Apr 28, 2019 • edited

Things done in the force push

worldofpeace left a comment

Choose a reason for hiding this comment

worldofpeace commented Apr 28, 2019

JohnAZoidberg commented Apr 28, 2019

jtojnar commented Apr 24, 2019 •

edited

JohnAZoidberg Apr 24, 2019 •

edited

jtojnar commented Apr 24, 2019 •

edited

JohnAZoidberg commented Apr 24, 2019 •

edited

worldofpeace commented Apr 28, 2019 •

edited