Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildPython*: allow overriding strictDeps #60178

Merged
merged 1 commit into from Apr 24, 2019
Merged

buildPython*: allow overriding strictDeps #60178

merged 1 commit into from Apr 24, 2019

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Apr 24, 2019

Motivation for this change

Fixes #59968

cc @worldofpeace @hedning @FRidh

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar jtojnar requested a review from FRidh as a code owner April 24, 2019 19:13
@worldofpeace
Copy link
Contributor

Shouldn't be problematic.

@jtojnar jtojnar force-pushed the buildpython-overridable-strictdeps branch from 4df957d to 83914f2 Compare April 24, 2019 20:27
@jtojnar jtojnar changed the base branch from staging to master April 24, 2019 20:27
@jtojnar
Copy link
Contributor Author

jtojnar commented Apr 24, 2019

Can confirm that this fixes guake. For reals this time.

@worldofpeace
Copy link
Contributor

Are we going to backport this?

@jtojnar
Copy link
Contributor Author

jtojnar commented Apr 24, 2019

Makes sense since the guake fix is in stable:

4c57db8

@jtojnar jtojnar merged commit a1535da into NixOS:master Apr 24, 2019
@jtojnar jtojnar deleted the buildpython-overridable-strictdeps branch April 24, 2019 21:41
@jtojnar jtojnar mentioned this pull request Apr 24, 2019
Merged
10 tasks
@jtojnar
Copy link
Contributor Author

jtojnar commented Apr 24, 2019

Backported in cf3e277

@dotlambda dotlambda mentioned this pull request Apr 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jtojnar @worldofpeace @matthewbauer