Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

electron_5: init at 5.0.0 #60192

Merged
merged 1 commit into from Apr 28, 2019
Merged

electron_5: init at 5.0.0 #60192

merged 1 commit into from Apr 28, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Apr 25, 2019

Motivation for this change

Copy of electron_4 expression with minor
addition of at-spi2-core which is needed to launch.

Not sure what apps are compatible just yet,
so haven't tried it beyond the base screen.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
electron_5: init at 5.0.0
259d23a 
Copy of electron_4 expression with minor
addition of at-spi2-core which is needed to launch.
@dtzWill
Copy link
Member Author

dtzWill commented Apr 26, 2019

cc @travisbhartwell @manveru

@dtzWill dtzWill merged commit b9aadff into NixOS:master Apr 28, 2019
@dtzWill dtzWill deleted the feature/electron-5 branch April 28, 2019 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@dtzWill