Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mesos: fix build by forcing protobuf 3.6 #60188

Merged
merged 1 commit into from May 11, 2019
Merged

mesos: fix build by forcing protobuf 3.6 #60188

merged 1 commit into from May 11, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Apr 25, 2019 •
edited

Motivation for this change

mesos really seems to want protobuf 3.3, as dictated by maven. 3.4 is the closest we have, but appears to do the job.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor

c0bw3b commented May 6, 2019

It was building fine with protobuf3_6 too. It would bring less friction later when we want to clean oldest versions of protobuf to pin this to 3.6.

The real solution would be an upgrade of Mesos (and Marathon and Spark) but that is a lot more work >__<

@risicle
Copy link
Contributor Author

risicle commented May 6, 2019

Yeah I wasn't sure which to go with - 3.4 or 3.6, but went with 3.4 because I've found that "tests passing" isn't everything.

@risicle
mesos: fix build by forcing protobuf 3.6
a6febf3 
mesos really seems to want protobuf 3.3, as dictated by maven. 3.6 does
seem to work though.
@risicle
Copy link
Contributor Author

risicle commented May 11, 2019

Switched to 3.6.

@c0bw3b
Copy link
Contributor

c0bw3b commented May 11, 2019

@GrahamcOfBorg build mesos

@c0bw3b c0bw3b changed the title mesos: fix build by forcing protobuf 3.4 mesos: fix build by forcing protobuf 3.6 May 11, 2019
@c0bw3b c0bw3b merged commit 8660acf into NixOS:master May 11, 2019
@c0bw3b
Copy link
Contributor

c0bw3b commented May 11, 2019

Less build failures! Thanks :)

@risicle risicle deleted the ris-mesos-fix branch May 11, 2019 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @c0bw3b