Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpop: 1.4.3 -> 1.4.4 #60190

Merged
merged 1 commit into from Apr 26, 2019
Merged

mpop: 1.4.3 -> 1.4.4 #60190

merged 1 commit into from Apr 26, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Apr 25, 2019

Motivation for this change

https://marlam.de/mpop/news/mpop-1-4-4/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

tomberek
tomberek approved these changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs on ubuntu, but did not test full functionality.

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/12

@dtzWill
Copy link
Member Author

dtzWill commented Apr 26, 2019

(minor touchup of pname, after doing some by request for #60189)

@dtzWill dtzWill merged commit 2acf9e9 into NixOS:master Apr 26, 2019
@dtzWill dtzWill deleted the update/mpop-1.4.4 branch April 26, 2019 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @nixos-discourse @tomberek