Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell: Introduce markUnbroken #60240

Merged
merged 1 commit into from Jul 16, 2019
Merged

haskell: Introduce markUnbroken #60240

merged 1 commit into from Jul 16, 2019

Conversation

bgamari
Copy link
Contributor

@bgamari bgamari commented Apr 26, 2019

Motivation for this change

Mark it easier to mark packages thought to be broken due only to version bounds as unbroken. See #59409.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@infinisil
Copy link
Member

You probably didn't mean to include those extra commits

@bgamari
haskell/lib: Introduce markUnbroken helper
cdf1a52 
As discussed in NixOS#59409, this is quite useful now since we mark things as
broken so liberally.
@bgamari
Copy link
Contributor Author

bgamari commented Jul 14, 2019

Rebased and dropped unintentional commits.

@infinisil infinisil merged commit 50dadfa into NixOS:master Jul 16, 2019
@infinisil
Copy link
Member

Sounds good, no reason to not merge this :)

@coderfromhere
Copy link

coderfromhere commented Jul 3, 2020 •
edited

How can I find this utility function in nixpkgs? There seems to be zero docs about it.

UPD: I searched through github commits and found nixpkgs.haskell.lib.markUnbroken. Still, a relevant section in https://nixos.org/nixpkgs/manual/#haskell would help a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bgamari @infinisil @coderfromhere