Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.03] torcs: fetch patch from stable source #60179

Merged
merged 2 commits into from Apr 24, 2019
Merged

[19.03] torcs: fetch patch from stable source #60179

merged 2 commits into from Apr 24, 2019

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Apr 24, 2019

Motivation for this change

Backport of #59316 to unbreak Torcs on the release

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@eri451 @c0bw3b
torcs: anonscm.debian.org has moved
941ff83 
the patch links where somewhat broken
my guess it is due to the move to a gitlab at salsa.debian.org
I used the non access required download link generated by gitlab

(cherry picked from commit acbdaa5)
@eri451 @c0bw3b
torcs: anonscm.debian.org has moved (NixOS#59316)
e60c4f5 
* torcs: anonscm.debian.org has moved

the patch links returned a HTTP error 401 as
anonscm.debian.org moved to a gitlab at salsa.debian.org
I used the non access required download link generated by the new instance
As @worldofpeace suggested in NixOS#58978 I used the last commit involving the files.

* torcs: add patch on OpenALMusicPlayer.cpp

Unbreak builds with GCC7

(cherry picked from commit 99b9166)
@c0bw3b
Copy link
Contributor Author

c0bw3b commented Apr 24, 2019

FYI @eri451 @astro

@c0bw3b c0bw3b merged commit aff2ba0 into NixOS:release-19.03 Apr 24, 2019
@c0bw3b c0bw3b deleted the backport/torcs branch April 24, 2019 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@c0bw3b @eri451