Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glulxe: init at 0.5.4 #60302

Closed
wants to merge 1 commit into from
Closed

glulxe: init at 0.5.4 #60302

wants to merge 1 commit into from

Conversation

kisonecat
Copy link
Contributor

Motivation for this change

glulxe is available in guix but not in nixpkgs

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

FRidh
FRidh reviewed Apr 27, 2019
View reviewed changes
pkgs/games/glulxe/default.nix
--replace "#GLKMAKEFILE = Make.glkterm" "GLKMAKEFILE = Make.glkterm"

cd ../glkterm
make
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is make invoked in the configure phase? I suppose you want to invoke it in the build phase? In that case, use preBuild and postBuild to change folder, and keep the default buildPhase, to ensure make gets invoked with makeFlags etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annoyingly to me as well, the Makefile in glkterm is acting more like "configure" than a build: it is producing the Make.glkterm which is then used by the build of glulxe.

JohnAZoidberg
JohnAZoidberg reviewed Apr 29, 2019
View reviewed changes
pkgs/games/glulxe/default.nix
--replace "#GLKMAKEFILE = Make.glkterm" "GLKMAKEFILE = Make.glkterm"

cd ../glkterm
make
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use make -C dir to execute the Makefile in an arbitrary subdirectory. That gets rid of the jumping in and out of directories.

@stale
Copy link

stale bot commented Jun 2, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 2, 2020
@Artturin Artturin closed this May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

@JohnAZoidberg JohnAZoidberg JohnAZoidberg left review comments

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kisonecat @FRidh @JohnAZoidberg @ryantm @Artturin