Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

httplz: init at 1.5.0 #60304

Merged
merged 2 commits into from Apr 27, 2019
Merged

httplz: init at 1.5.0 #60304

merged 2 commits into from Apr 27, 2019

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Apr 27, 2019

Motivation for this change

Note that the project's name is "http" and it provides 2 identical binaries ("http" and "httplz").

"http" collides with the very popular httpie's "http" so I named the package "httplz" and I only build the "httplz" binary.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@JohnAZoidberg
Copy link
Member

"http" collides with the very popular httpie's "http" so I named the package "httplz" and I only build the "httplz" binary.

Good catch! Well we could include the http binary and change the priorities so that httpie overrides this. But I think that adds an unnecessary maintenance burden for us. A user who wants the shorter name can just add an alias for themself.

Built and tested it - works fine :)

@FRidh FRidh merged commit 4d8b9cb into NixOS:master Apr 27, 2019
@bbigras bbigras deleted the httplz branch April 27, 2019 11:57
@bbigras
Copy link
Contributor Author

bbigras commented Apr 27, 2019

Thanks!

@bbigras bbigras mentioned this pull request Apr 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnAZoidberg JohnAZoidberg JohnAZoidberg approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bbigras @JohnAZoidberg @FRidh