Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kfind: was not mentioned in all-packages.nix #60244

Merged
merged 1 commit into from Apr 26, 2019
Merged

kfind: was not mentioned in all-packages.nix #60244

merged 1 commit into from Apr 26, 2019

Conversation

peterhoeg
Copy link
Member

Motivation for this change

kfind was all there - just not mentioned in all-packages.nix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@peterhoeg peterhoeg changed the title kfind: was not referenced in all-packages.nix kfind: was not mentioned in all-packages.nix Apr 26, 2019
@peterhoeg peterhoeg merged commit 65e3d0d into NixOS:master Apr 26, 2019
@peterhoeg peterhoeg deleted the f/kfind branch April 26, 2019 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@peterhoeg