New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grip-0.8: indexed grip #60182
grip-0.8: indexed grip #60182
Conversation
3fab489
to
1b91817
Compare
Is there a clean way to solve project names clash? |
Oh... I see what is going on... never realized there was a ping @jtojnar as a gnome expert and all around great person 😄 |
I would suggest choosing |
It is not my application :) I just found it useful in my job. Named attribute to grip-search. Probably no need to remove existing grip - at most if anyone use both there will be clash in names (grip), but I do not think too many people will want to use grip-search and grip together. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry this I haven't got back to this until now. This dropped off my radar.
On top of the suggestions I have made you should probably rename the file from grip.nix
to grip-search.nix
so it matches the attribute name.
After you're done with the changes please squash all commits into a single commit with message grip-search: init at 0.8
.
@aanderse Hi, please see changes. |
Hi, is there anything else needed to to to get this merged? |
@JohnAZoidberg happy to be left out, |
Yes I tested it on Windows. Crosscompiled on NixOS targeted Windows and run in Wine and native Windows10.
…On November 12, 2019 10:26:50 PM GMT+01:00, Daniel Schaefer ***@***.***> wrote:
JohnAZoidberg commented on this pull request.
> + sha256 = "0bkqarylgzhis6fpj48qbifcd6a26cgnq8784hgnm707rq9kb0rx";
+ };
+
+ nativeBuildInputs = [ pkgconfig cmake ];
+
+ buildInputs = [ boost ];
+
+ patchPhase = ''
+ sed -i -e 's/"CUSTOM-BUILD"/${version}/' src/general/config.h
+ '';
+
+ meta = with stdenv.lib; {
+ description = "Fast, indexed regexp search over large file trees";
+ homepage = "https://github.com/sc0ty/grip";
+ license = licenses.gpl3;
+ platforms = platforms.linux ++ platforms.windows;
You tested it on Windows?
I think we shouldn't exclude MacOS because it is very likely to work.
We can exclude it, once somebody notices it doesn't work there.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#60182 (comment)
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
I tested crosscompile when I first submitted this merge request, but trying it now (with updated nixpkgs) leads to:
I submitted this as bug #73420 |
Funny, it works, I tried to cross compile grip (the gui application) which failed. grip-search works. |
Oh, I tested that crosscompilation when I first created this merge request. |
Or is it problem of #73195 that it doesn't provide all in runtime required libraries in resulting output? |
@tex We have always lacked a sufficiently good automated mechanism for copying all of the required DLLs into the |
grip-0.8: indexed grip (cherry picked from commit c96e556)
Motivation for this change
New CLI application for indexed grepping. Fast. Useful. Can be cross-compiled for Windows.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)