Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testssl: 2.9.5-7 -> 3.0rc5 #60183

Merged
merged 3 commits into from May 1, 2019
Merged

testssl: 2.9.5-7 -> 3.0rc5 #60183

merged 3 commits into from May 1, 2019

Conversation

etu
Copy link
Contributor

@etu etu commented Apr 24, 2019

Motivation for this change

These updates aren't really in sequence as the numbers would suggest, but I decided to update and clean it up a bit to latest 2.9.5-8 and then to 3.0rc4.
Changelog: https://github.com/drwetter/testssl.sh/releases/tag/v2.9.5-8
Changelog: https://github.com/drwetter/testssl.sh/releases/tag/3.0rc4

The reasoning for this is that I'm going to backport 2.9.5-8 to stable and then have unstable upgraded to 3.0rc4.

Upstream have stressed for a while that 3.0 is the new supported series but I think our stable can be fine on 2.9.5-8 for the rest of the lifetime.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@etu etu changed the title Testssl upgrades testssl: 2.9.5-7 -> 3.0rc4 Apr 24, 2019
@etu
Copy link
Contributor Author

etu commented Apr 25, 2019

Don't merge this yet, they just released rc5 https://github.com/drwetter/testssl.sh/releases/tag/3.0rc5

I'm going to add rc5 on this PR later today.

@peterhoeg
Copy link
Member

Do you mind patching the main script as well to get rid of the ugly .testssl.sh-wrapped name:

~ $ testssl.sh --help | head
     ".testssl.sh-wrapped [options] <URI>"    or    ".testssl.sh-wrapped <options>"


".testssl.sh-wrapped <options>", where <options> is:

     --help                        what you're looking at
     -b, --banner                  displays banner + version of .testssl.sh-wrapped
     -v, --version

@etu
Copy link
Contributor Author

etu commented Apr 25, 2019

@peterhoeg Fixed :-)

@etu etu changed the title testssl: 2.9.5-7 -> 3.0rc4 testssl: 2.9.5-7 -> 3.0rc5 Apr 25, 2019
@etu etu mentioned this pull request May 1, 2019
10 tasks
@etu etu merged commit 175f25d into NixOS:master May 1, 2019
@etu etu deleted the testssl-upgrades branch May 1, 2019 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants