Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hugo: 0.55.3 -> 0.55.4 #60205

Merged
merged 1 commit into from Apr 26, 2019
Merged

hugo: 0.55.3 -> 0.55.4 #60205

merged 1 commit into from Apr 26, 2019

Conversation

callahad
Copy link
Member

@callahad callahad commented Apr 25, 2019 •
edited

Motivation for this change

Version bump.

Things done

Built and ran. Compiled my site. It works.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@callahad
Copy link
Member Author

...another day, another minor hugo release.

If someone could kick a build off with ofborg, I'd appreciate it.

@ofborg ofborg bot requested a review from kalbasit April 25, 2019 11:39
@kalbasit
Copy link
Member

@GrahamcOfBorg build hugo

tomberek
tomberek approved these changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs on Ubuntu, no reverse dependencies

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/12

matthiasbeyer
matthiasbeyer approved these changes Apr 26, 2019
View reviewed changes
Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks good to me.

@kalbasit kalbasit merged commit 4c5aff0 into NixOS:master Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit kalbasit approved these changes

@tomberek tomberek tomberek approved these changes

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@callahad @kalbasit @nixos-discourse @tomberek @matthiasbeyer