Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cedille: 1.0.0 -> 1.1.1 #60307

Merged
merged 1 commit into from Apr 29, 2019
Merged

cedille: 1.0.0 -> 1.1.1 #60307

merged 1 commit into from Apr 29, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Apr 27, 2019

Motivation for this change

Changelog: https://github.com/cedille/cedille/blob/master/CHANGELOG.md#cedille-11

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

tomberek
tomberek approved these changes Apr 27, 2019
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up the expression! builds/runs on Ubuntu, did not test compiler output

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/12

@timokau
Copy link
Member

timokau commented Apr 29, 2019

Thanks, the cleanups look good!

For the future (not important enough to hold off merge here), its generally better to add yourself as a maintainer in a separate commit.

@timokau
Copy link
Member

timokau commented Apr 29, 2019

Aarch64 failure seems to be a faulty ofBorg instance.

@timokau timokau merged commit 7a965dc into NixOS:master Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marsam @nixos-discourse @timokau @tomberek