Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restic: 0.9.4 -> 0.9.5 #60156

Merged
merged 1 commit into from Apr 25, 2019
Merged

restic: 0.9.4 -> 0.9.5 #60156

merged 1 commit into from Apr 25, 2019

Conversation

dotlambda
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

tomberek
tomberek approved these changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs on Ubuntu. no reverse dependencies.

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/12

@dotlambda dotlambda merged commit 5847b2a into NixOS:master Apr 25, 2019
@dotlambda dotlambda deleted the restic-0.9.5 branch April 25, 2019 15:15
@davidak
Copy link
Member

davidak commented May 6, 2019

Could you also backport it to 19.03? It fixes a problem with restore i currently have (restic/restic@bf9a507).

dotlambda pushed a commit that referenced this pull request May 6, 2019
restic: 0.9.4 -> 0.9.5 (#60156)
8c6c85d 
(cherry picked from commit 5847b2a)
@dotlambda
Copy link
Member Author

@davidak done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dotlambda @nixos-discourse @davidak @tomberek