[Experiment] Separate security wrappers from NixOS #60289
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Recently I had to use a nix-shell that installs setuid wrappers for some package-specific dependencies. Because the security wrapper logic was so deeply embedded in NixOS, I had to use NixOS to make the nix-shell work.
This change allows you to set up security wrappers in your nix-shells with the same functionality as in NixOS. E.g. this should work:
Or this is how you could build it directly:
Only very minimal tests were done, but it seems to work just fine. If anybody needs it, here you go.
I also made minor changes like quoting all bash variables and removing some legacy code that didn't do anything (
WRAPPER_PATH
).Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)