Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approving/Rejecting blockings is broken #3908

Closed
mic4ael opened this issue Apr 25, 2019 · 0 comments · Fixed by #3912
Closed

Approving/Rejecting blockings is broken #3908

mic4ael opened this issue Apr 25, 2019 · 0 comments · Fixed by #3912
Assignees
Projects

Comments

@mic4ael
Copy link
Member

mic4ael commented Apr 25, 2019

This is because we are abusing disabled fields for the 'view' mode, but we now set disabled on the <Form.Field> when a field is disabled, so all mouse events are disabled (and an opacity is applied).

Two possible solutions:

  1. add a disableFieldWrapper={false} prop so no disabled prop is set on the <Form.Field> even if the field is disabled
  2. Do not disable the fields at all but set a readOnly prop (and implement it correctly in the custom fields used in the blocking modal)

I think (2) is the cleaner solution since disabled fields are usually just disabled, and don't suddenly hide the UI related to changing things...

@mic4ael mic4ael created this issue from a note in Release 2.2 (In progress) Apr 25, 2019
@mic4ael mic4ael self-assigned this Apr 25, 2019
@mic4ael mic4ael moved this from In progress to Awaiting Merge in Release 2.2 Apr 29, 2019
Release 2.2 automation moved this from Awaiting Merge to Done May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Release 2.2
  
Done
Development

Successfully merging a pull request may close this issue.

1 participant