Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update service worker resource timing test to use {{hosts[alt]}} #16571

Merged
merged 1 commit into from May 15, 2019

Conversation

youennf
Copy link
Contributor

@youennf youennf commented Apr 26, 2019

No description provided.

Copy link
Member

@mfalken mfalken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks right. Could you add something to commit description to mention why this is better? I guess it's something like "alt" is the guaranteed other domain per https://web-platform-tests.org/writing-tests/server-features.html and it can be used without depending on get-host-info.js or hardcoding www1.

hosts[alt] works in more configurations than domains[www1].
See web-platform-tests#15692 for background information
@youennf youennf merged commit 811f222 into web-platform-tests:master May 15, 2019
@youennf
Copy link
Contributor Author

youennf commented May 15, 2019

Updated commit comment and merged it.

@youennf youennf deleted the webkit-197329 branch May 15, 2019 16:00
marcoscaceres pushed a commit that referenced this pull request Jul 23, 2019
)

hosts[alt] works in more configurations than domains[www1].
See #15692 for background information
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants