Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libobjc: 1.8.1 -> 1.9 -> 2.0 #60296

Closed
wants to merge 3 commits into from
Closed

libobjc: 1.8.1 -> 1.9 -> 2.0 #60296

wants to merge 3 commits into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Apr 26, 2019

Motivation for this change

Builds on #60295, moving to 2.0!

I'm not sure if we want to stick with 1.x or not, hence the two PR's.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from matthewbauer April 26, 2019 23:16
@dtzWill
Copy link
Member Author

dtzWill commented Apr 27, 2019

@GrahamcOfBorg build gnustep

@dtzWill dtzWill mentioned this pull request Apr 27, 2019
Merged
10 tasks
@ajs124
Copy link
Member

ajs124 commented Feb 3, 2020

2.0 is already on master since #62464. Which coincidentally made SoGo segfault for us after the 19.09 upgrade.

@ajs124 ajs124 mentioned this pull request Feb 3, 2020
Merged
10 tasks
@dtzWill
Copy link
Member Author

dtzWill commented Feb 13, 2020

As mentioned, seems already included. Thanks, sorry for the stall! :)

@dtzWill dtzWill closed this Feb 13, 2020
@ajs124
Copy link
Member

ajs124 commented Feb 13, 2020

I'm honestly not sure bumping was the right thing to do. As noted in #79175, it makes at least some software segfault. I'm not sure anyone else uses libobjc for anything else, so I actually revert the bump in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @ajs124