Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openjdk8: Try to remove host kernel version impurity #60292

Merged
merged 1 commit into from Apr 27, 2019
Merged

openjdk8: Try to remove host kernel version impurity #60292

merged 1 commit into from Apr 27, 2019

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Apr 26, 2019

Motivation for this change

The openjdk build appears to check something like uname to determine the kernel version. This options disables that check, because it's broken at least on linux 5.x. I am frankly not sure whether this is the correct solution, but surely such a version check is an impurity regardless.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from edwtjo and NeQuissimus April 26, 2019 22:37
@NeQuissimus NeQuissimus merged commit b4275f6 into NixOS:master Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeQuissimus NeQuissimus NeQuissimus approved these changes

@FRidh FRidh FRidh approved these changes

@edwtjo edwtjo Awaiting requested review from edwtjo

Assignees
No one assigned
Labels
6.topic: reproducible builds 10.rebuild-darwin: 0 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@srhb @NeQuissimus @FRidh