nixos/tinc: remove ordering dependency on network.target #60231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows configuring IP addresses on a tinc interface using
networking.interfaces."tinc.${n}".ipv[46].addresses.
Previously, this would fail with timeouts, because of the dependency
chain
tinc.${netname}.service
--after--> network.target
--after--> network-addresses-tinc.${n}.service (and network-link-…)
--after--> sys-subsystem-net-devices-tinc.${n}.device
But the network interface doesn't exist until tinc creates it! So
systemd waits in vain for the interface to appear, and by then the
network-addresses-* and network-link-* units have failed. This leads
to the network link not being brought up and the network addresses not
being assigned, which in turn stops tinc from actually working.
|
Are there any disadvantages to this solution though? |
|
I'll just go ahead and merge this if I don't hear anything by Monday, given that this is for master and we're still early in the 19.09 release cycle. |
|
I've tested this shortly in my staging deployment, seems to work OK (though I didn't analyse it in great detail). So merging is fine by me. |
nh2
approved these changes
May 8, 2019
|
@volth are you planning to test this? If not I'd just go ahead and merge it. |
|
I've added {
wantedBy = lib.mkForce ["sys-subsystem-net-devices-tinc.lugnet.device"];
before = lib.mkForce [];
partOf = ["sys-subsystem-net-devices-tinc.lugnet.device"];
after = ["sys-subsystem-net-devices-tinc.lugnet.device"];
serviceConfig.Type = lib.mkForce "simple";
serviceConfig.Restart = "on-failure";
serviceConfig.RestartSec = 10;
}to |
|
For me that did the trick: systemd.services."tinc.${meshName}".after = [ "tinc.${meshName}-netdev.service" ]; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows configuring IP addresses on a tinc interface using
networking.interfaces."tinc.${n}".ipv[46].addresses.
Previously, this would fail with timeouts, because of the dependency
chain
But the network interface doesn't exist until tinc creates it! So
systemd waits in vain for the interface to appear, and by then the
network-addresses-* and network-link-* units have failed. This leads
to the network link not being brought up and the network addresses not
being assigned, which in turn stops tinc from actually working.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)cc @volth frequent contributor to tinc module