Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oauth2_proxy: 20180325 -> 3.2.0 #60233

Merged
merged 1 commit into from Apr 30, 2019
Merged

oauth2_proxy: 20180325 -> 3.2.0 #60233

merged 1 commit into from Apr 30, 2019

Conversation

nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented Apr 25, 2019 •
edited

Motivation for this change

after bitly repo was frozen pusher is now the official hard fork
bitly/oauth2_proxy#628

the module will need more testing to see if anything is broken

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

marsam
marsam requested changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@marsam marsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like it uses dep to manage its dependencies, can you update deps.nix with https://github.com/nixcloud/dep2nix. Besides that, LGTM

@nyanloutre
oauth2_proxy: 20180325 -> 3.2.0
a47124d 
after bitly repo was frozen, pusher is now the official hard fork
bitly/oauth2_proxy#628
@nyanloutre
Copy link
Member Author

@marsam done

@marsam
Copy link
Contributor

marsam commented Apr 30, 2019

@GrahamcOfBorg build oauth2_proxy

@marsam marsam merged commit 9d23245 into NixOS:master Apr 30, 2019
@marsam
Copy link
Contributor

marsam commented Apr 30, 2019

@nyanloutre thanks!

@nyanloutre nyanloutre deleted the oauth2_proxy_update branch April 30, 2019 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nyanloutre @marsam