nixos: configurable system-wide malloc #60187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg test hardened |
ajs124
reviewed
Apr 24, 2019
Lassulus
reviewed
Apr 30, 2019
Currently, this uses the somewhat crude method of setting LD_PRELOAD in the system environment. This works, but should be considered a stepping stone to a more robust solution.
joachifm
force-pushed
the
feat/configurable-malloc
branch
from
08829bf
to
10d3a0e
Compare
|
|
|
+1, I just ended up tracking nix OOMs to this PR as well. |
|
(If you're looking for another potential hardened allocator, Scudo has seen some good amounts of battle-testing. I suspect it might have less side effects.) |
|
See also #61489 |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A more general alternative to #59955 that allows choosing among a predefined set of providers. The implementation is pretty bad but does "work". Ideally this would be improved upon later.
If this variant is deemed too much for the niche functionality it provides, I'm happy to go back to a more limited version under hardened. (From my pov, only the hardened allocator is really of interest).