Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rmount: init at 1.0.1 #60204

Merged
merged 3 commits into from Apr 25, 2019
Merged

rmount: init at 1.0.1 #60204

merged 3 commits into from Apr 25, 2019

Conversation

Qubasa
Copy link
Contributor

@Qubasa Qubasa commented Apr 25, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Qubasa Qubasa mentioned this pull request Apr 25, 2019
Closed
9 tasks
aanderse
aanderse requested changes Apr 25, 2019
View reviewed changes
pkgs/tools/filesystems/rmount/default.nix Outdated Show resolved Hide resolved
pkgs/tools/filesystems/rmount/default.nix Outdated Show resolved Hide resolved
pkgs/tools/filesystems/rmount/default.nix Outdated Show resolved Hide resolved
pkgs/tools/filesystems/rmount/default.nix Outdated Show resolved Hide resolved
maintainers/maintainer-list.nix Outdated Show resolved Hide resolved
@aanderse aanderse merged commit 827e954 into NixOS:master Apr 25, 2019
@aanderse
Copy link
Member

@luis-hebendanz thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhoeg peterhoeg peterhoeg left review comments

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Qubasa @aanderse @peterhoeg