Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cryptsetup: create /run/cryptsetup #60235

Merged
merged 1 commit into from Apr 28, 2019
Merged

cryptsetup: create /run/cryptsetup #60235

merged 1 commit into from Apr 28, 2019

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Apr 25, 2019

Needed since 2.0.0
Changed to /run/cryptsetup from /run/lock/cryptsetup in 2.0.1

Motivation for this change

Seeing the warning on boot was getting annoying.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@eadwu
cryptsetup: create /run/cryptsetup
1fc2338 
Needed since 2.0.0
Changed to /run/cryptsetup from /run/lock/cryptsetup in 2.0.1
@eadwu eadwu requested a review from infinisil as a code owner April 25, 2019 22:06
@eadwu
Copy link
Member Author

eadwu commented Apr 25, 2019

The warning didn't cause any problems anyway, as far as I can tell.

WARNING: Locking directory /run/cryptsetup is missing!

@joachifm joachifm merged commit 162546f into NixOS:master Apr 28, 2019
@eadwu eadwu mentioned this pull request Apr 29, 2020
Closed
@eadwu eadwu deleted the cryptsetup/systemd-tmpfile branch November 17, 2020 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eadwu @joachifm