Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pydf: init at 12 #60236

Merged
merged 2 commits into from Apr 26, 2019
Merged

pydf: init at 12 #60236

merged 2 commits into from Apr 26, 2019

Conversation

monsieurp
Copy link
Member

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

meta = with stdenv.lib; {
description = "colourised df(1)-clone";
homepage = http://kassiopeia.juls.savba.sk/~garabik/software/pydf/;
license = licenses.publicDomain;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@grahamc
Copy link
Member

grahamc commented Apr 25, 2019

@GrahamcOfBorg build pydf

@grahamc
Copy link
Member

grahamc commented Apr 25, 2019

@GrahamcOfBorg build pydf

Copy link
Member

@grahamc grahamc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at some other examples of Python code, it looks like fetchPypi comes from python3Packages, and not the general function definition -- I think these changes should do the trick. Give it a try and test locally with nix-build ./path/to/nixpgks/checkout -A pydf ?

pkgs/applications/misc/pydf/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/pydf/default.nix Outdated Show resolved Hide resolved
@grahamc
Copy link
Member

grahamc commented Apr 25, 2019

@GrahamcOfBorg build pydf

@grahamc
Copy link
Member

grahamc commented Apr 25, 2019

Those are the successes I was looking for!

@monsieurp
Copy link
Member Author

👍

@grahamc
Copy link
Member

grahamc commented Apr 25, 2019 via email

@grahamc grahamc merged commit 06d90aa into NixOS:master Apr 26, 2019
@grahamc
Copy link
Member

grahamc commented Apr 26, 2019

Nicely done, thank you!

@monsieurp
Copy link
Member Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants