New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pydf: init at 12 #60236
pydf: init at 12 #60236
Conversation
meta = with stdenv.lib; { | ||
description = "colourised df(1)-clone"; | ||
homepage = http://kassiopeia.juls.savba.sk/~garabik/software/pydf/; | ||
license = licenses.publicDomain; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@GrahamcOfBorg build pydf |
@GrahamcOfBorg build pydf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at some other examples of Python code, it looks like fetchPypi comes from python3Packages, and not the general function definition -- I think these changes should do the trick. Give it a try and test locally with nix-build ./path/to/nixpgks/checkout -A pydf
?
@GrahamcOfBorg build pydf |
Those are the successes I was looking for! |
👍 |
Looks good! I’ll merge it when I get home if nobody else gets it first.
Nice work!
… On Apr 25, 2019, at 18:46, monsieurp ***@***.***> wrote:
👍
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Nicely done, thank you! |
👍 |
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)