Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rush: 1.8 -> 1.9 #60161

Merged
merged 1 commit into from Apr 26, 2019
Merged

rush: 1.8 -> 1.9 #60161

merged 1 commit into from Apr 26, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Apr 24, 2019

Motivation for this change

http://lists.gnu.org/archive/html/info-gnu/2019-04/msg00007.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
Copy link
Contributor

risicle commented Apr 24, 2019

Works for me, non-nixos linux x86_64.

@dtzWill dtzWill merged commit e5453a1 into NixOS:master Apr 26, 2019
@dtzWill dtzWill deleted the update/rush-1.9 branch April 26, 2019 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants