Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tmuxPlugins.vim-tmux-navigator: fix runtimepath #60165

Merged
merged 1 commit into from Apr 26, 2019
Merged

Conversation

NickHu
Copy link
Contributor

@NickHu NickHu commented Apr 24, 2019

Motivation for this change

I was using home-manager to manage my tmux configuration when I noticed that the vim-tmux-navigator plugin didn't seem to work.

After some investigation, I found that the generated runtimepath for the vim-tmux-navigator plugin was broken:

$ nix repl
Welcome to Nix version 2.2.2. Type :? for help.

nix-repl> :l <nixpkgs>
Added 10237 variables.

nix-repl> pkgs.tmuxPlugins.vim-tmux-navigator.rtp
"/nix/store/kad7bgna5f6halc84xc793y9c8602iy2-tmuxplugin-vim-tmux-navigator/share/tmux-plugins/vim-tmux-navigator/vim_tmux_navigator.tmux"

This file doesn't exist, but /nix/store/kad7bgna5f6halc84xc793y9c8602iy2-tmuxplugin-vim-tmux-navigator/share/tmux-plugins/vim-tmux-navigator/vim-tmux-navigator.tmux does. I tracked down the culprit, which was a call to builtins.replaceStrings changing the - for _ and removed it; I have no idea why it's there. Perhaps @kalbasit can explain? I added a rtpFilePath for vim-tmux-navigator to fix this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kalbasit
Copy link
Member

kalbasit commented Apr 24, 2019

That was always in place, I merely moved it to a variable so we can customize it through a plugin. I'm not sure why it's there either, but I assume that most plugins are formatted this way. Instead of removing it, please set the variable rtpFilePath as it's done in the fzf-tmux-url plugin.

@NickHu NickHu changed the title tmux-plugins: fix runtimepath vim-tmux-navigator: fix runtimepath Apr 26, 2019
@NickHu
Copy link
Contributor Author

NickHu commented Apr 26, 2019

@kalbasit Done!

@kalbasit kalbasit changed the title vim-tmux-navigator: fix runtimepath tmuxPlugins.vim-tmux-navigator: fix runtimepath Apr 26, 2019
@kalbasit kalbasit merged commit 6c28c29 into NixOS:master Apr 26, 2019
@NickHu NickHu deleted the tmux branch April 28, 2019 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants