Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetbrains updates #60267

Merged
merged 10 commits into from Apr 27, 2019
Merged

Jetbrains updates #60267

merged 10 commits into from Apr 27, 2019

Conversation

averelld
Copy link
Contributor

Motivation for this change

Update via script. Tested (only) idea together with #60208.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@averelld averelld requested a review from edwtjo as a code owner April 26, 2019 14:12
@BenBals
Copy link
Contributor

BenBals commented Apr 26, 2019 •
edited

Reviewed points
  • package path fits guidelines
  • package name fits guidelines
  • package version fits guidelines
  • package build on ARCHITECTURE
  • executables tested on ARCHITECTURE
  • meta.description is set and fits guidelines
  • meta.license fits upstream license
  • meta.platforms is set
  • meta.maintainers is set
  • build time only dependencies are declared in nativeBuildInputs
  • source is fetched using the appropriate function
  • phases are respected
  • patches that are remotely available are fetched with fetchpatch
Possible improvements
Comments

I am still building this. Will report back.

@MP2E
Copy link

MP2E commented Apr 27, 2019

LGTM, works on my machine

@MP2E MP2E merged commit 238d4fb into NixOS:master Apr 27, 2019
@BenBals
Copy link
Contributor

BenBals commented Apr 27, 2019

I tested IDEA Ultimate and Community successfully. Didnt get around to all the others.

@averelld averelld deleted the jetbrains-updates branch April 29, 2019 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwtjo edwtjo Awaiting requested review from edwtjo edwtjo is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@averelld @BenBals @MP2E