Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patchShebangs: create timestamp in tmp dir #60215

Merged
merged 1 commit into from Apr 25, 2019
Merged

patchShebangs: create timestamp in tmp dir #60215

merged 1 commit into from Apr 25, 2019

Conversation

nmattia
Copy link
Contributor

@nmattia nmattia commented Apr 25, 2019 •
edited

Creating the timestamp in the patched script's directory has a few
drawbacks:

  • if "foo.timestamp" already exists, it will be overwritten
  • it requires the directory to be writable
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nmattia
patchShebangs: create timestamp in tmp dir
cc9b402 
Creating the timestamp in the patched script's directory has a few
drawbacks:

* if "foo.timestamp" already exists, it will be overwritten
* it requires the directory to be writable
@grahamc grahamc changed the base branch from master to staging April 25, 2019 15:08
@grahamc grahamc merged commit a682d72 into NixOS:staging Apr 25, 2019
@nmattia nmattia deleted the nm-tmp-timestamp branch April 25, 2019 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314 Ericson2314 is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nmattia @grahamc