New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
home-assistant: 0.91.4 -> 0.92.2 #60217
Conversation
47a4366
to
56601ad
Compare
56601ad
to
186a4ae
Compare
This breaks transifex-client, which requires cc @etu |
Sigh, that damn package. It probably doesn't require that really. It has made lots of absurd claims in the past. I'll look into this tomorrow at work (in about 8-9 hours or so). I already patch the package to get rid of some of the absurd claims of required versions of deps. But yeah, I need it so I'll fix it somehow. |
A number of platforms failed to initialize for me:
|
Ahh wait, while this is the package used, the module is still the one from stable and thus without the mentioned commit. |
@dotlambda I have tested building transifex locally, and changing this line:
|
186a4ae
to
fe65a43
Compare
Tried again:
If I add the component in extra packages then works. |
The nixpkgs version used to build your system, not the one Home Assistant is built from, must include the patch. That's because it's the NixOS module's task to detect the used components. |
I understand, I really like to select which packages I prefer bleeding edge in my system without affecting system wide. So I can keep with my workaround. Or do you know how can I override only that module? |
That patch will be backported to 19.03, so you won't have to change anything. But for testing, you have to build from a local nixpkgs checkout of your channel with the patch appied. |
The `availableComponents` now only contain a single attribute for every integration.
10b7c48
to
7e09b53
Compare
I'll merge on 2019-05-05 20:00 UTC if there's no further comment until then. |
Motivation for this change
https://www.home-assistant.io/blog/2019/04/24/release-92/
This was a complex update due to home-assistant/core#22699.
The
parse-requirements.py
script needed quite some changes to account for the newmanifest.json
. But the new code turned out shorter than the old one.I also have completely rewritten the code that accounts for the
platform = "component"
way of configuration. The respective commit (d280603) should be backported. This will make it rather useless to useautoExtraComponents
with a pre-0.92 version of Home Assistant. Is this something that should be possible?Due to the extensive changes, I invite everyone to test thoroughly. Please bear in mind that you will need to apply d280603 to your nixpkgs checkout if you build your system from one of the release channels.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)cc @netixx