service_identity: 17.0.0 -> 18.1.0 #60216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: python
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
labels
marsam
requested changes
Apr 30, 2019
There was a problem hiding this comment.
looks like the dependencies changed as well. Can you update them?
diff --git c/pkgs/development/python-modules/service_identity/default.nix i/pkgs/development/python-modules/service_identity/default.nix
index 93e172a4f60..daa5d117779 100644
--- c/pkgs/development/python-modules/service_identity/default.nix
+++ i/pkgs/development/python-modules/service_identity/default.nix
@@ -22,8 +22,8 @@ buildPythonPackage rec {
};
propagatedBuildInputs = [
- characteristic pyasn1 pyasn1-modules pyopenssl idna attrs
- ];
+ pyasn1 pyasn1-modules idna attrs cryptography
+ ] ++ lib.optionals (pythonOlder "3.3") [ ipaddress ];
checkInputs = [ pytest ];
checkPhase = "py.test";besides that, LGTM
Newer version of Twisted requires newer version of service_identity for reasonable certificate subject checking.
|
@GrahamcOfBorg build pythonPackages.service-identity pythonPackages.twisted pythonPackages.scrapy python3Packages.service-identity python3Packages.twisted python3Packages.scrapy magic-wormhole |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer version of Twisted requires newer version of service_identity for reasonable certificate subject checking.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)