Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dragonfly-reverb: 1.0.0 -> 1.1.4 #60275

Merged
merged 1 commit into from Apr 27, 2019
Merged

dragonfly-reverb: 1.0.0 -> 1.1.4 #60275

merged 1 commit into from Apr 27, 2019

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Apr 26, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@JohnAZoidberg
Copy link
Member

The update looks good, still builds.
But you only package the library - why not also copy the graphical application to the output? :)

JohnAZoidberg
JohnAZoidberg reviewed Apr 26, 2019
View reviewed changes
pkgs/applications/audio/dragonfly-reverb/default.nix Outdated
@@ -6,8 +6,8 @@ stdenv.mkDerivation rec {
src = fetchFromGitHub {
owner = "michaelwillis";
repo = "dragonfly-reverb";
rev = "1.0.0";
sha256 = "05m4hd8lg0a7iiia6cbiw5qmc4p8vbkxp2qh7ywaabawiwa9r24x";
rev = "1.1.4";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can now use pname = "dragonfly-reverb" and version = "1.1.4". Nix will automatically concatenate them.
Then you can do:

Suggested change
rev = "1.1.4";
rev = version;

and also repo = pname

@JohnAZoidberg
Copy link
Member

The license was changed to GPL3: michaelwillis/dragonfly-reverb@8196962#diff-9879d6db96fd29134fc802214163b95a

@magnetophon
Copy link
Member Author

Thanks for the feedback and good catch on the license!
All done.

@FRidh FRidh merged commit b41cff9 into NixOS:master Apr 27, 2019
@magnetophon magnetophon deleted the dragonfly-reverb branch April 27, 2019 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnAZoidberg JohnAZoidberg JohnAZoidberg left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@magnetophon @JohnAZoidberg @FRidh